Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates README.md file, adds typescript defintions #3

Closed
wants to merge 1 commit into from
Closed

Updates README.md file, adds typescript defintions #3

wants to merge 1 commit into from

Conversation

n0minal
Copy link

@n0minal n0minal commented Aug 16, 2019

This update adds typescript definitions and fixes README.md file :)

@pirxpilot
Copy link
Owner

Thanks.
I am not accepting PRs with types definitions for my modules. Same reasons as in Sindre's response.
As I am sure you know, you can fork and maintain TS version of this module, or submit the types to something like DefinitelyTyped
I'll cherry pick your changes to the Readme file though. Looks like I did not clean it up after forking.
Thanks again.

@pirxpilot pirxpilot closed this Aug 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@n0minal @pirxpilot