chore: use tsup for building; package.json exports for better compat

[bienzaaron]

Swaps the existing build scripts out for tsup and sets package.json exports fields for the best compatibility with typescript.

I tested with the repro from the linked issue with moduleResolution modes: bundler, node, nodenext (plus module: nodenext as that's required), and node16 - all work with the updated exports field.

closes #32

[bienzaaron]

This can be moved into package.json if desired, but when in a typescript/javascript file, you get type hints from your editor, which is why I put it in its own config.

[bienzaaron]

tsc was removed, but with dts: true, tsup will call tsc.

[benknoble]

cc @jasnell what can we do to help move this forward?

[benknoble]

cc @mcollina any way to push this forward ?

[mcollina]

I currently do not have time

[benknoble]

@mcollina thanks for letting us know; do you know who else we can reach as maintainers that might have time to review this and move it forward?

[mcollina]

@metcoder95 ?

[metcoder95]

👋

sorry for the delay, I oversight the notification. I will take a look at it this weekend and get back to you. thanks!

[benknoble]

Thank you all !!

[metcoder95]

Can resolve the conflicts?

After that, it lgtm

[metcoder95]

Lint seems failing

[bienzaaron]

I had to change the export = {...} to get the tests passing. I was getting the error:

test/locks.ts 2> /Users/fsb984/work/oss/piscina-locks/node_modules/ts-node/src/index.ts:859
test/locks.ts 2>     return new TSError(diagnosticText, diagnosticCodes, diagnostics);
test/locks.ts 2>            ^
test/locks.ts 2> TSError: ⨯ Unable to compile TypeScript:
test/locks.ts 2> test/locks.ts(6,3): error TS2614: Module '".."' has no exported member 'request'. Did you mean to use 'import request from ".."' instead?
test/locks.ts 2> test/locks.ts(7,3): error TS2614: Module '".."' has no exported member 'query'. Did you mean to use 'import query from ".."' instead?
test/locks.ts 2> test/locks.ts(8,3): error TS2614: Module '".."' has no exported member 'version'. Did you mean to use 'import version from ".."' instead?
test/locks.ts 2>
test/locks.ts 2>     at createTSError (/Users/fsb984/work/oss/piscina-locks/node_modules/ts-node/src/index.ts:859:12)
test/locks.ts 2>     at reportTSError (/Users/fsb984/work/oss/piscina-locks/node_modules/ts-node/src/index.ts:863:19)
test/locks.ts 2>     at getOutput (/Users/fsb984/work/oss/piscina-locks/node_modules/ts-node/src/index.ts:1077:36)
test/locks.ts 2>     at Object.compile (/Users/fsb984/work/oss/piscina-locks/node_modules/ts-node/src/index.ts:1433:41)
test/locks.ts 2>     at Module.m._compile (/Users/fsb984/work/oss/piscina-locks/node_modules/ts-node/src/index.ts:1617:30)
test/locks.ts 2>     at module.exports (/Users/fsb984/work/oss/piscina-locks/node_modules/default-require-extensions/js.js:7:9)
test/locks.ts 2>     at /Users/fsb984/work/oss/piscina-locks/node_modules/append-transform/index.js:64:4
test/locks.ts 2>     at require.extensions.<computed> (/Users/fsb984/work/oss/piscina-locks/node_modules/ts-node/src/index.ts:1621:12)
test/locks.ts 2>     at Object.<anonymous> (/Users/fsb984/work/oss/piscina-locks/node_modules/append-transform/index.js:64:4)
test/locks.ts 2>     at Module.load (node:internal/modules/cjs/loader:1288:32) {
test/locks.ts 2>   diagnosticCodes: [ 2614, 2614, 2614 ]
test/locks.ts 2> }

This should be mostly equivalent, except a default key is added to the CJS version.
with test.cjs:

const def = require('.');
console.log(def);

const { request, query, version } = require('.');
console.log(request, query, version);

and test.mjs:

import def from "./dist/lib/index.mjs";
import { query, request, version } from "./dist/lib/index.mjs";
console.log(def);
console.log(request, query, version);

before this change:

> node test.cjs
{
  request: [AsyncFunction: request],
  query: [Function: query],
  version: '3.0.0'
}
[AsyncFunction: request] [Function: query] 3.0.0

> node test.mjs 
{
  request: [AsyncFunction: request],
  query: [Function: query],
  version: '3.0.0'
}
[AsyncFunction: request] [Function: query] 3.0.0

after this change:

> node test.mjs
{
  request: [AsyncFunction: request],
  query: [Function: query],
  version: '3.0.0'
}
[AsyncFunction: request] [Function: query] 3.0.0

> node test.cjs
{
  default: [Getter],
  query: [Getter],
  request: [Getter],
  version: [Getter]
}
[AsyncFunction: request] [Function: query] 3.0.0

[metcoder95]

No worries, that should be fine

[benknoble]

Now there are some C++ compilation errors? Hm

[metcoder95]

I'll take a look later Today

[bienzaaron]

Okay, this one should go through 😅 it was pulling in node 23 headers, which was causing problems. Didn't happen on my machine, because it's a corporate device and it doesn't have access to 23 yet. I added a --target argument matching the node version that is currently installed (so it would match the github actions version, or whatever is installed locally). I can update that to whatever version, but it does appear to need to be an exact version - just 22 won't work, for example.

[metcoder95]

Thanks, that should solve it, now there's an issue with the artifacts we upload; let me fix it so you can rebase with current

[metcoder95]

Can you update your branch with current?

[metcoder95]

The command doesn't work for windows bc of the subshell.

[metcoder95]

Sorry for the extremely long reply, completely missed the PR;
let me take it back soon on this