-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: expose task interface #565
Conversation
metcoder95
commented
May 15, 2024
- chore: split worker pool and task queue implementation
- refactor: remove leftovers
I'm trying to decouple the Task Queue and Worker Pool implementation so they can grow independently, mostly aiming for enable the work for #536 and do it progressively; I'd target the new balancer work directly to |
05e58f4
to
963ae88
Compare
6de079f
to
b56e61c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it semver-major?
Don't think so, wasn't exported before, but if we want to be careful, we can do so |
7fc3357
to
95a6335
Compare
465ec32
to
479ab7c
Compare
Just wanted to verify if is true that we did not expose these types, and indeed we don't. import type { Task } from 'piscina/dist/types'; Which is not officially supported, instead to access the same types they can do: import type { PiscinaTask } from 'piscina'; |
I'll be merging the PR, if there's extra feedback, feel free to add it here and I'll address it in further PR |