feat(#305)!: Expose new PiscinaHistogram abstraction
#723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronag
previously approved these changes
Jan 6, 2025
|
Should we automatically reset the histogram at some interval? |
RafaelGSS
reviewed
Jan 6, 2025
| @@ -110,6 +110,53 @@ Use caution when setting resource limits. Setting limits that are too low may | |||
| result in the `Piscina` worker threads being unusable. | |||
| ::: | |||
|
|
|||
| ## `PiscinaHistogram` | |||
|
|
|||
| The `PiscinaHistogram` allows you to access the histogram data for the pool of worker threads. | |||
There was a problem hiding this comment.
Can we have a code sample on how users would do it in userland?
There was a problem hiding this comment.
Done, let me know if that's enough or if there's a something else to cover
I don't think so, since we are storing distribution data (mean, avg, stddev) |
RafaelGSS
approved these changes
Jan 9, 2025
metcoder95
changed the title
PiscinaHistogram abstraction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #305