You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Bug discovered in 6279509. Reproducing the commit message:
[Flashcards/KELLIA] Run make flashcards test to pick up changes.
The changes are supposed to affect formatting only. However, they seem
to have caused the flashcards pipeline to insert a lot of tags
unnecessarily.
Here is how this happened:
We start wrapping the source XML files at 80 characters.
Our KELLIA binary reads them, and passes the content as is to the
output TSV's.
Our Flashcards binary reads the TSV's, and replaces the newline
characters with tags.
This looks like a bug that need to be resolved. Let's do it when we are
more fluent in KELLIA! (The code is mostly copied.)
#140 introduced a parameter to help solve the problem.
I believe the path forward is:
The KELLIA pipeline produces well-formatted HTML.
In the Flashcards pipeline, we do NOT convert any newlines to <br/> tags.
P.S. It's cleaner to do the above for all Flashcard pipelines.
The text was updated successfully, but these errors were encountered:
Running `make flashcards test` does NOT introduce any changes, as
intended.
This ensures that all instances where you replace newlines with line
breaks are visible with a search for the string `line_br=True`.
Bug discovered in 6279509. Reproducing the commit message:
#140 introduced a parameter to help solve the problem.
I believe the path forward is:
<br/>
tags.P.S. It's cleaner to do the above for all Flashcard pipelines.
The text was updated successfully, but these errors were encountered: