Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HTML] Make Pages Prettier #171

Closed
pishoyg opened this issue Aug 11, 2024 · 1 comment
Closed

[HTML] Make Pages Prettier #171

pishoyg opened this issue Aug 11, 2024 · 1 comment
Assignees
@pishoyg
Labels
freelance How: A freelancer can do it maintenance What: Small fix UI Why: Better user interface user Why: User convenience
Milestone
Site v1.0

Comments

@pishoyg
Copy link
Owner

pishoyg commented Aug 11, 2024

It's not too appealing right now. Prettify it, somehow!
@pishoyg pishoyg added the user Why: User convenience label Aug 11, 2024
pishoyg added a commit that referenced this issue Aug 12, 2024
@pishoyg
[#171][Flashcards] Remove "key: " from the link bar at the top.
2559e8b
pishoyg added a commit that referenced this issue Aug 12, 2024
@pishoyg
[#171][Flashcards] Remove the word "key: " from the top bar.
f1e4228
@pishoyg pishoyg added freelance How: A freelancer can do it UI Why: Better user interface labels Aug 13, 2024
@pishoyg pishoyg changed the title [HTML] Make the Page Prettier [HTML] Make Pages Prettier Aug 21, 2024
pishoyg added a commit that referenced this issue Aug 21, 2024
@pishoyg
[#171][Crum/HTML] Use "email" instead of "contact".
419b8bf 
"contact" is too long for the phone view!
pishoyg added a commit that referenced this issue Aug 21, 2024
@pishoyg
[#171][Crum/Flashcards] Run make flashcards to pick up "email".
f3fef55
pishoyg added a commit that referenced this issue Aug 22, 2024
@pishoyg
[#171][Crum/Flashcards] Add a Second <br/> when Images are Absent.
f1b6927 
Otherwise, the following `<hr/>` would collide with the dictionary pages
lists.
pishoyg added a commit that referenced this issue Aug 22, 2024
@pishoyg
[#171][Crum/Flashcards] Run make flashcards test.
6e1d1df 
Pick up the `<br/>` tag that makes up for the absence of explanatory
images.
pishoyg added a commit that referenced this issue Aug 23, 2024
@pishoyg
[#171,#212][Crum/Site] Don't Encode the Search Parameter.
7de92b0 
It looks prettier, especially with the comma-separated dialects.

P.S. #212 is referenced because this was brought up in one of the
comments on it.
pishoyg added a commit that referenced this issue Sep 3, 2024
@pishoyg
[#171][Crum/Flashcards] Put Spaces after Commas in Dawoud Pages List.
36c9cae 
The rendering is otherwise not friendly on Anki on a phone's narrow
screen.
Perhaps there is some HTML magic that we can do to make the rendering
better, but right now having a long connected string of text without any
spaces makes it ugly!
pishoyg added a commit that referenced this issue Sep 3, 2024
@pishoyg
'[#225,#171][Crum/Flashcards] Run make flashcards.
180d347 
- Pick up `rel` links.
- Pick up spaces after commas in the Dawoud page list.
pishoyg added a commit that referenced this issue Sep 4, 2024
@pishoyg
[#171,#229][Crum/Flashcards] Add a Line Break between Meaning and Crum.
f7691b8 
This is obviously related to #171, but you might be wondering how it has
anything to do with #229.
The answer is that, with the current HTML, some text extractors see
"Crum" and whatever precedes it as a single word, thus messing up with
our search function (and also with text highlighting experience in the
browser). Adding a line break is a way to ensure that this doesn't
happen.
pishoyg added a commit that referenced this issue Sep 8, 2024
@pishoyg
[#233,#171][Crum/Flashcards] Insert a <br> if Images are Absent.
b79af33 
This existed, but was mistakenly removed in
f9c7165, perhaps under the assumption
that the use of `<div>` tags would render the line breaks unnecessary.
It's necessary to have two line breaks, not just one, when the images
are absent; in order for the horizontal line to avoid conflict with the
"dictionary" division.
pishoyg added a commit that referenced this issue Sep 8, 2024
@pishoyg
[#233,#171][Crum/Flashcards] Run make flashcards to Pick up <br> …
309ef9e 
…Tags.
@pishoyg pishoyg added the maintenance What: Small fix label Sep 9, 2024
@pishoyg pishoyg added this to coptic Sep 11, 2024
pishoyg added a commit that referenced this issue Sep 13, 2024
@pishoyg
[#171][Crum/Flashcards] Remove Line Breaks between Explanatory Images.
20dcd3e 
It makes the display much better.
pishoyg added a commit that referenced this issue Sep 13, 2024
@pishoyg
[#171][Crum/Flashcards] Run make flashcards.
f3aac2b 
Allow explanatory images to be adjacent.
@pishoyg pishoyg modified the milestones: Pipeline: Site, Site v1.0 Sep 14, 2024
@pishoyg pishoyg self-assigned this Sep 14, 2024
pishoyg added a commit that referenced this issue Sep 14, 2024
@pishoyg
[#171][Site/CSS] Update Home Page Styling.
4b330c9
pishoyg added a commit that referenced this issue Sep 14, 2024
@pishoyg
[#171][Site/CSS] Include the 'style.css' at the Root in all HTML Files.
39abbc0
@pishoyg pishoyg closed this as completed Sep 14, 2024
@pishoyg
Copy link
Owner Author

pishoyg commented Sep 14, 2024

Looks appealing enough for me!

pishoyg added a commit that referenced this issue Sep 15, 2024
@pishoyg
[#171,#241][Site/CSS] Crum and Home Share a CSS File.
f7d9d32 
This keeps things simple and localized, and will make it possible to
reuse the styling for other subpages as well.
pishoyg added a commit that referenced this issue Sep 15, 2024
@pishoyg
[#171][Site/CSS] Remove a Superfluous Reference to a CSS Sheet.
333f971 
Since 39abbc0, this CSS file gets
linked in all HTML files, so this line is redundant.
pishoyg added a commit that referenced this issue Oct 24, 2024
@pishoyg
[#171][Crum/Flashcards/CSS] Use a Small Font for Editor's Notes.
86ba63a
pishoyg added a commit that referenced this issue Oct 24, 2024
@pishoyg
[#171][Crum/Flashcards/CSS] Run make flashcards test to Pick up Style.
9e554f8
pishoyg added a commit that referenced this issue Nov 21, 2024
@pishoyg
[#171][Crum/Flashcards] Insert a Space Following Crum Page Numbers.
7ed6d41
pishoyg added a commit that referenced this issue Nov 21, 2024
@pishoyg
[#171][Crum/Flashcards] Run make flashcards test.
f69a1cd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pishoyg pishoyg

Labels
freelance How: A freelancer can do it maintenance What: Small fix UI Why: Better user interface user Why: User convenience
Projects
coptic
Archived in project
Milestone
Site v1.0
Development

No branches or pull requests
1 participant
@pishoyg