Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Site] Next and Prev should Skip Pages not Containing Selected Dialects #190

Open
pishoyg opened this issue Aug 14, 2024 · 3 comments
Open
Labels
fun Why: Fun

Comments

@pishoyg
Copy link
Owner

pishoyg commented Aug 14, 2024

Following up on #122, we've been using JavaScript for the dialected variants. The site should be smart enough to skip through pages that have neither a word nor a derivation belonging to any of the selected dialect.

You can do this by redirecting to the "next" link. Maybe also display a popup! Waiting for a second before doing it would also be nice!

#62 is somewhat related. We might be able to solve both by having the Crum pipeline export a piece of metadata, representing all dialects present in a word1.

Footnotes

  1. A word in the context of Crum refers to a dictionary entry, with all the spellings and derivations - that's a note in the Flashcards context, or a page in the Site context.

@pishoyg pishoyg added the user Why: User convenience label Aug 14, 2024
@pishoyg pishoyg added this to the Initial Site milestone Aug 14, 2024
@pishoyg
Copy link
Owner Author

pishoyg commented Aug 14, 2024

NOTE: Handle the case when zero dialects are selected!
NOTE: Handle the case when undialected root spellings are present. (Undialected derivation spellings have no significance.)

@pishoyg pishoyg added rigor UI Why: Better user interface and removed rigor labels Aug 17, 2024
@pishoyg
Copy link
Owner Author

pishoyg commented Aug 23, 2024

There is no need to include any extra metadata in the website. Checking for the presence of an element bearing the dialect code should suffice.
But we might want to change the HTML slightly to include classes that distinguish between roots and derivations, in order to handle the case of undialected roots (which have to receive a different treatment from undialected derivations).

@pishoyg
Copy link
Owner Author

pishoyg commented Aug 23, 2024

NOTE: We're removing these buttons from Anki! See.

@pishoyg pishoyg added this to coptic Sep 11, 2024
@pishoyg pishoyg added fun Why: Fun and removed user Why: User convenience UI Why: Better user interface labels Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fun Why: Fun
Projects
Status: No status
Development

No branches or pull requests

1 participant