-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Flashcards/HTML] Use JavaScript for the Dialected Variants #122
Milestone
Comments
Note: Here are some ideas:
Note: You have another use case for JavaScript: #134. |
This was referenced Aug 8, 2024
pishoyg
added a commit
that referenced
this issue
Aug 11, 2024
pishoyg
added a commit
that referenced
this issue
Aug 11, 2024
pishoyg
added a commit
that referenced
this issue
Aug 11, 2024
pishoyg
added a commit
that referenced
this issue
Aug 11, 2024
pishoyg
added a commit
that referenced
this issue
Aug 11, 2024
pishoyg
added a commit
that referenced
this issue
Aug 11, 2024
pishoyg
added a commit
that referenced
this issue
Aug 11, 2024
pishoyg
added a commit
that referenced
this issue
Aug 11, 2024
pishoyg
added a commit
that referenced
this issue
Aug 11, 2024
pishoyg
added a commit
that referenced
this issue
Aug 11, 2024
pishoyg
added a commit
that referenced
this issue
Aug 11, 2024
pishoyg
added a commit
that referenced
this issue
Aug 11, 2024
pishoyg
added a commit
that referenced
this issue
Aug 11, 2024
pishoyg
added a commit
that referenced
this issue
Aug 11, 2024
pishoyg
added a commit
that referenced
this issue
Aug 11, 2024
pishoyg
added a commit
that referenced
this issue
Aug 11, 2024
pishoyg
added a commit
that referenced
this issue
Aug 11, 2024
It doesn't have any impact, besides a harmless error message: ``` TypeError: Cannot read properties of null (reading 'split') ``` Still, it's cleaner to avoid it.
We have made great progress here!
|
This was referenced Aug 11, 2024
pishoyg
added a commit
that referenced
this issue
Aug 11, 2024
We add "type", "spelling-comma", "dialect-comma", and "dialect-parenthesis" classes!
pishoyg
added a commit
that referenced
this issue
Aug 11, 2024
pishoyg
added a commit
that referenced
this issue
Aug 11, 2024
pishoyg
added a commit
that referenced
this issue
Aug 11, 2024
pishoyg
added a commit
that referenced
this issue
Aug 11, 2024
pishoyg
added a commit
that referenced
this issue
Aug 13, 2024
The default rule `site_publish` creates a fixup commit and pushes it. The dev rule `site_prepublish` only creates a commit. This is a followup to f7d506e.
Status:
Summary TODO:
|
See #181. |
Status:
Summary TODO:
|
Deprioritizing (by unassigning) because the current status is good enough. |
pishoyg
added a commit
that referenced
this issue
Aug 19, 2024
We also don't append the query parameters to the navigate URLs since they are already stored in the local storage. Also use the smarter `url.searchParams.set` method, instead of relying on raw string manipulation.
pishoyg
added a commit
that referenced
this issue
Nov 18, 2024
We have been moving away from dialect variants, and we now prefer using the same format for all dialects, relying on highlighting to focus on certain dialects as needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
You are already generating one for Bohairic / Sahidic. Create one for all dialects, it should be straightforward.
Then you get your Bohairic-first behaviour (which is requested in #102). But also, it's much simpler, cleaner, and more dialect-neutral.
The text was updated successfully, but these errors were encountered: