Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flashcards] Delete Unused Media from the Output #96

Open
pishoyg opened this issue Aug 2, 2024 · 5 comments
Open

[Flashcards] Delete Unused Media from the Output #96

pishoyg opened this issue Aug 2, 2024 · 5 comments
Labels
backlog What: Low-impact / low-priority dev Why: Developer experience

Comments

@pishoyg
Copy link
Owner

pishoyg commented Aug 2, 2024

Right now, our media class records all media files regardless of whether or not they actually ended up being used. This results in the output (HTML and Anki) containing lots of unused media files. Revisit.

@pishoyg
Copy link
Owner Author

pishoyg commented Aug 4, 2024

This happens due to the cards that end up without a front or a back, so they get dropped from the package. Their media files would've been included anyway!

@pishoyg
Copy link
Owner Author

pishoyg commented Aug 5, 2024

The dialected HTML pages will become less important as we make progress on #122, because it's more likely then that we will focus on the all-dialect HTML outputs only.
However, this will continue to be, technically, a bug.

@pishoyg
Copy link
Owner Author

pishoyg commented Aug 5, 2024

Idea: Can you retrieve the media per card, rather than per field? 🤔

@pishoyg pishoyg added dev Why: Developer experience and removed backlog dev Why: Developer experience labels Aug 8, 2024
pishoyg added a commit that referenced this issue Aug 31, 2024
@pishoyg
Copy link
Owner Author

pishoyg commented Aug 31, 2024

This is not problematic at the moment. We will reopen if that changes.

@pishoyg pishoyg closed this as not planned Won't fix, can't repro, duplicate, stale Aug 31, 2024
@pishoyg pishoyg added this to coptic Sep 11, 2024
@pishoyg pishoyg reopened this Sep 14, 2024
@pishoyg
Copy link
Owner Author

pishoyg commented Sep 14, 2024

I changed my mind. This belongs in the backlog, not in README.

@pishoyg pishoyg added the backlog What: Low-impact / low-priority label Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog What: Low-impact / low-priority dev Why: Developer experience
Projects
Status: No status
Development

No branches or pull requests

1 participant