Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layer name text wrapping disrupts layer list #559

Closed
epicabsol opened this issue Oct 25, 2016 · 4 comments
Closed

Layer name text wrapping disrupts layer list #559

epicabsol opened this issue Oct 25, 2016 · 4 comments
Labels

Comments

@epicabsol
Copy link
Contributor

To reproduce, start a new piskel and create a new layer. Name it something long with spaces. Ensure that the top layer with the long name is selected.
Observed behavior: The long layer name will wrap to the next line in the layer list, showing behind.
screenshot 2016-10-25 at 2 33 39 pm
Additionally, if there is a word without spaces in the layer title, the layers list will grow horizontally.
screenshot 2016-10-25 at 2 35 23 pm

Expected behavior: The long layer name is truncated, perhaps with an ellipsis, or the layer list item grows vertically, but doesn't overwrite the next layer title.

@juliandescottes
Copy link
Collaborator

Thanks for the report @epicabsol !

@GMartigny
Copy link
Contributor

@juliandescottes What's prefered : Elipsis or vertical grow ?

@juliandescottes
Copy link
Collaborator

@GMartigny I think we should go for an ellipsis, and make sure that the title attribute is properly set with the name of the layer.

GMartigny pushed a commit to GMartigny/piskel that referenced this issue Dec 1, 2016
juliandescottes added a commit that referenced this issue Dec 6, 2016
Add ellipsis to overflowing layer item name #559
GMartigny pushed a commit to GMartigny/piskel that referenced this issue Dec 8, 2016
@juliandescottes
Copy link
Collaborator

Fixed by @GMartigny

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants