Use layer name as filename prefix in zip export #786
Conversation
…prefix to file names (in ZipExportController) if checkbox is selected.
|
Thanks for the nice feedback and for the PR. The idea sounds good, I'll review the change this weekend. |
| @@ -11,7 +11,11 @@ | |||
| <input id="zip-split-layers" class="zip-split-layers-checkbox checkbox-fix" type="checkbox" /> | |||
| <label for="zip-split-layers">Split by layers</label> | |||
| </div> | |||
| <div class="use-layer-names-checkbox-container" style="margin: 5px 0;"> | |||
There was a problem hiding this comment.
We should keep the checkbox-container class here, since it slightly influences the display. This way the text for both checkboxes will be correctly aligned.
Feel free to go with a shorter name for the other class e.g. class="checkbox-container use-layer-names-container"
|
|
||
| this.useLayerNamesCheckboxContainer = document.querySelector('.use-layer-names-checkbox-container'); | ||
| this.useLayerNamesCheckbox = document.querySelector('.zip-use-layer-names-checkbox'); | ||
| this.useLayerNamesCheckboxContainer.hidden = !this.splitByLayersCheckbox.checked; |
There was a problem hiding this comment.
Could we hide this with CSS? Either set style.display set to block or none. Or classList.toggle("hidden", !this.splitByLayersCheckbox.checked);
|
|
||
| this.useLayerNamesCheckboxContainer = document.querySelector('.use-layer-names-checkbox-container'); | ||
| this.useLayerNamesCheckbox = document.querySelector('.zip-use-layer-names-checkbox'); | ||
| this.useLayerNamesCheckboxContainer.hidden = !this.splitByLayersCheckbox.checked; |
There was a problem hiding this comment.
This could also get into its own method so that we can call it from here and from onSplitLayersClick_?
|
Makes sense! I'll make those changes and push an update. Thanks. |
|
Looks good, thanks for addressing the comments @sharpfives ! Merging. I'm preparing release v0.14 right now so your change should be available very soon on piskelapp.com :) |
|
@juliandescottes No problem, thanks again for making this. Also nice work keeping the code clean and organized - made it super easy for me to get up and running. |
Hi!
Piskel is such a great project; I use it all the time for making scenes and characters in my video games. Thanks for making this!
I'd like to have the exported layers optionally start with the layer name, rather than the layer index. For most of my games, I'm copying over the exported layers and frames from Piskel into another project, and then referencing them by filename in the game code. If I need to come back to Piskel and add another layer in the middle of others are re-export, my the existing layers' filenames are now shifted due to the index change and my game code's file references are wrong. Optionally using the layer name in the exported files rather than index would allow easier migration of files to other projects that aren't expecting layer file names to change each time.
I added a new checkbox to the zip export html template to enable this option, and supporting logic to the zip export controller. The new checkbox should not show unless the "split by layers" options is checked.
Let me know what you think.
Thanks again,
Alex