Prepare gensim v3.8.2 to pin smart_open for Py2.7 compatibility #2787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piskvorky
reviewed
Apr 9, 2020
Co-Authored-By: Radim Řehůřek <me@radimrehurek.com>
mpenkov
reviewed
Apr 10, 2020
There was a problem hiding this comment.
@piskvorky @menshikh-iv We should make a 3.8.2 release with minimum changes (essentially, just this pin). I've pushed some changes to prepare the next release - please have a look.
My plan is to merge this onto master and make the release from that branch. Please let me know what you think.
mpenkov
changed the title
|
@mpenkov sounds good for me, but please fix appveyor before that |
|
Thank you for taking care of Appveyor @menshikh-iv !!! |
mpenkov
added a commit
that referenced
this pull request
Apr 28, 2020
* pin version of smart-open to py2 compatible * add a comment Co-Authored-By: Radim Řehůřek <me@radimrehurek.com> * make pin conditional (py27 only) * prepare version 3.8.2 * add deprecations to README * get rid rackcdn, bump scipy to 1.0.0 * bump scipy to 1.0.0 in setup.py Co-authored-by: Yury Brukau <brukau@ebu.ch> Co-authored-by: Radim Řehůřek <me@radimrehurek.com> Co-authored-by: Michael Penkov <misha.penkov@gmail.com> Co-authored-by: Ivan Menshikh <menshikh.iv@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pin version of smart-open to <1.11.
Pull request to master as soon as gensim develop seems to be Python3 only.
Fixes #2786.