Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix doc entry for corpus_iterable in train #2945

Closed
wants to merge 1 commit into from
Closed

Fix doc entry for corpus_iterable in train #2945

wants to merge 1 commit into from

Conversation

svenski
Copy link

@svenski svenski commented Sep 15, 2020

Fix doc entry for corpus_iterable in train (previously sentences).

Fix doc entry for `corpus_iterable` in `train` (previously `sentences`).
@svenski svenski changed the title Fix doc entry for corpus_iterable in train Fix doc entry for corpus_iterable in train Sep 15, 2020
Copy link
Owner

@piskvorky piskvorky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. One more little improvement, to clarify the motivation for "streamed input".

gensim/models/fasttext.py Show resolved Hide resolved
@svenski svenski closed this Sep 15, 2020
@svenski
Copy link
Author

svenski commented Sep 15, 2020

Hmm, sorry, closing the commit was the wrong thing to do, re-opening!

@svenski svenski reopened this Sep 15, 2020
@gojomo
Copy link
Collaborator

gojomo commented Sep 16, 2020

Note that another in-progress PR #2944, in the course of fixing & cleaning up other things, has eliminated the FastText.train() method entirely in favor of simply sharing the implementation from Word2Vec.

I've made sure the Word2Vec.train() comment is similarly fixed in that PR via this commit, so this PR is now superfluous.

Thanks for pointing this out, though, & please keep highlighting/proposing fixes for such errors!

@svenski
Copy link
Author

svenski commented Sep 16, 2020

Ah, ok, no worries, thanks for letting me know.

@svenski svenski closed this Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants