Skip to content

Commit

Permalink
Fix merge artifact (#323)
Browse files Browse the repository at this point in the history
Two separate PRs were touching the same code. [1] modified the bucket
handling to perform it at module load time. In the meanwhile, [2] fixed
a broken test by relying on functionality that wasn't around after [1]
got merged.

[1] #318
[2] #322
  • Loading branch information
mpenkov authored May 31, 2019
1 parent 635f539 commit a7fecfa
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions smart_open/tests/test_s3.py
Original file line number Diff line number Diff line change
Expand Up @@ -382,8 +382,6 @@ def test_nonexisting_bucket(self):
fout.write(expected)

def test_read_nonexisting_key(self):
create_bucket_and_key()

with self.assertRaises(ValueError):
with smart_open.s3.open(BUCKET_NAME, 'my_nonexisting_key', 'rb') as fin:
fin.read()
Expand Down

0 comments on commit a7fecfa

Please sign in to comment.