Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove old bz2file dependency #300

Closed
mpenkov opened this issue Apr 18, 2019 · 0 comments · Fixed by #309
Closed

Remove old bz2file dependency #300

mpenkov opened this issue Apr 18, 2019 · 0 comments · Fixed by #309

Comments

@mpenkov
Copy link
Collaborator

mpenkov commented Apr 18, 2019

piskvorky/gensim#2448
@mpenkov mpenkov mentioned this issue Apr 24, 2019
Merged
mpenkov added a commit that referenced this issue Apr 26, 2019
@mpenkov
Minor fixes: bz2file dependency, paramiko warning handling (#309)
a5bdd65 
* move paramiko import and warning deeper into code

* improve register_compressor example

* fixup in deprecated smart_open function

multipart_upload_kwargs shouldn't contain endpoint_url.
That parameter is only for resource_kwargs.

* remove bz2file dependency, fix #300

* Revert "remove bz2file dependency, fix #300"

This reverts commit 84a008a.

* make bz2file a dependency only under Py2, fix #300

* re-raise ImportError on failure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Minor fixes: bz2file dependency, paramiko warning handling
1 participant
@mpenkov