Replace ParsedUri class with functions, cleanup internal argument parsing
#191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
menshikh-iv
reviewed
Apr 22, 2018
There was a problem hiding this comment.
Good work @mpenkov, please update PR description: add motivation part (why this important/needed/better).
|
|
||
|
|
||
| def _parse_uri_hdfs(parsed_uri): | ||
| assert parsed_uri.scheme == 'hdfs' |
There was a problem hiding this comment.
Why asserts needed (you check exact same conditions before in if/elif), here and everywhere? Sanity-check only?
There was a problem hiding this comment.
Yes, it's a sanity check only.
smart_open/smart_open_lib.py
Outdated
|
|
||
| Some of the above options only make sense for certain protocols, e.g. | ||
| bucket_id is only for S3.""" | ||
| Uri.__new__.__defaults__ = (None,) * len(Uri._fields) |
There was a problem hiding this comment.
definitely need a comment here, too hacky
menshikh-iv
changed the title
ParsedUri class with functions, cleanup internal argument parsing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is better than what we previously had for two reasons.
First, we now know what options we parse from a URI up front. Previously, this was only possible by reading the relatively long ParsedUri constructor. Now, we just look at the fields of the namedtuple. This makes the code easier to understand, debug and improve. For example, it now becomes obvious that we don't actually use the ordinary_calling_format option anywhere: we just parse it.
Second, we make the code easier to understand by replacing a class with a data structure (namedtuple) and a parsing function. The previous ParsedUri class was really a function masquerading as a function - this is considered un-Pythonic. If a class is being used as a function, it should really just be a function.