Correctly pass newline parameter to built-in open function

[burkovae]

Motivation

It appears, that newline parameter is missing when smart_open uses the buildin open method.
This one is essential, e.g. when writing csv files under windows

• Fixes Output using csv module is inconsistent with traditional open behaviour #477

Tests

See test case.

• Please @maintainers, run the complete test suite, because (i) I lack the infrastructre for testing google and aws stuff (tests are not passing from master branch) and (ii) I'm not able to test against Macs and Unix systems.
• Please review the parameter position. I put it to the end, so that nothing will break in the first palce. But I may be sensible to put it into the same place as open would expect.
• I noticed unused parameter kw and removed it as well, no harm done ❤️

Checklist

Before you create the PR, please make sure you have:

• Picked a concise, informative and complete title (hopefully 🙉 )
• Clearly explained the motivation behind the PR
• Linked to any existing issues that your PR will be solving
• Included tests for any new functionality
• Checked that all unit tests pass (need support from maintainer here 🥇 )

[mpenkov]

I've pushed some changes to polish up your PR. Can you please run the tests on your end and confirm that they pass?

In the future, we'll really need to run tests on Windows as part of our CI. #161

[burkovae]

Thank you for the edits. I now remember, why temprorary files are quite nasty under Windows 🔥

Whether the name can be used to open the file a second time, while the named temporary file is still open, varies across platforms (it can be so used on Unix; it cannot on Windows NT or later)

This is the reason, why the test fails atm.

What do you think ?

[mpenkov]

Can you please tweak the test so that it passes? I can't reproduce the problem without Windows, unfortunately. I'd do something like this:

import contextlib

@contextlib.contextmanager
def win_compatible_tempfile(mode):
    with tempfile.NamedTemporaryFile(mode, delete=False) as f:
        try:
            yield f
        finally:
            f.close()
            os.unlink(f.name)

based on this comment bravoserver/bravo#111 (comment)
The reason I use tempfile is because I want to avoid writing to the present working directory. It's poor practice.

[mpenkov]

Please pull from develop and look for a function called named_temporary_file. Use it to work around the problem.

[burkovae]

Thank you for your suggestions and improvements. The test is green (at least locally.). Sorry, it took so long to respond.

[mpenkov]

This looks like a merge conflict

[burkovae]

Oi! Thanks, strangely git status didn't told me.

[mpenkov]

Finally got around to merging this. Good work @burkovae , and congrats on your first PR to smart_open! 🥇