Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

following up on #589, adjust manifest #591

Merged
merged 1 commit into from
Mar 6, 2021
Merged

following up on #589, adjust manifest #591

merged 1 commit into from
Mar 6, 2021

Conversation

mpenkov
Copy link
Collaborator

@mpenkov mpenkov commented Mar 5, 2021 •
edited
Loading

  • Adjust MANIFEST.in as suggested by @piskvorky
  • Remove test package data from setup.py

@mpenkov mpenkov mentioned this pull request Mar 5, 2021
Merged
5 tasks
@mpenkov mpenkov requested a review from piskvorky March 5, 2021 01:49
@mpenkov
Copy link
Collaborator Author

mpenkov commented Mar 5, 2021

@e-nalepa Please have a look in case we missed anything else

@piskvorky
Copy link
Owner

piskvorky commented Mar 5, 2021 •
edited
Loading

Thanks.

What's the workflow for testing locally now, after this PR?

@mpenkov
Copy link
Collaborator Author

mpenkov commented Mar 5, 2021

Same as before, "python setup.py develop; pytest smart_open".

@mpenkov mpenkov merged commit 96a1317 into develop Mar 6, 2021
@mpenkov mpenkov deleted the testdata branch March 6, 2021 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piskvorky piskvorky piskvorky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mpenkov @piskvorky