Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix AttributeError when reading passthrough zstandard #658

Merged
merged 2 commits into from
Oct 10, 2021
Merged

fix AttributeError when reading passthrough zstandard #658

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
227afdf
fix AttributeError when reading passthrough zstandard
mpenkov Oct 10, 2021
47ed330
Update CHANGELOG.md
mpenkov Oct 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

- Use pytest instead of parameterizedtestcase (PR [#657](https://github.com/RaRe-Technologies/smart_open/pull/657), [@mpenkov](https://github.com/mpenkov))
- Support container client and blob client for azure blob storage (PR [#652](https://github.com/RaRe-Technologies/smart_open/pull/652), [@cbare](https://github.com/cbare))
- Fix AttributeError when reading passthrough zstandard (PR [#658](https://github.com/RaRe-Technologies/smart_open/pull/658), [@mpenkov](https://github.com/mpenkov))

# 5.2.1, 28 August 2021

Expand Down
6 changes: 5 additions & 1 deletion smart_open/smart_open_lib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,7 +387,11 @@ def _open_binary_stream(uri, mode, transport_params):
# if there is no such an attribute, we return "unknown" - this
# effectively disables any compression
if not hasattr(uri, 'name'):
uri.name = getattr(uri, 'name', 'unknown')
name = getattr(uri, 'name', 'unknown')
try:
uri.name = name
except AttributeError:
pass
return uri

if not isinstance(uri, str):
Expand Down