added buffer_size parameter to http module #730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpenkov
approved these changes
Oct 16, 2022
|
Thank you @mullenkamp !! |
davidparks21
pushed a commit
to davidparks21/smart_open
that referenced
this pull request
Oct 18, 2022
davidparks21
pushed a commit
to davidparks21/smart_open
that referenced
this pull request
Oct 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Added the buffer_size parameter to the http module. This provides more functionality to the http module and is more consistent with the other modules that support it already. The base code for the buffer_size was already there, it was just set to a default buffer size without the option for user input.
Sorry it took so long for me to get to this...
Tests
The pytest for test_http.py ran successfully (locally).
Checklist
Before you create the PR, please make sure you have: