Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Google Cloud Storage to use blob.open #744

Merged
merged 11 commits into from
Dec 9, 2022
Merged

Refactor Google Cloud Storage to use blob.open #744

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
1b36f9f
Fixes #599
cadnce Sep 17, 2022
9d183bb
Use the underlying google-storage-blob instead of writing a proxy.
cadnce Oct 10, 2022
d702599
Fix lint issues
cadnce Oct 10, 2022
ebff7cb
Restore original apis
cadnce Oct 13, 2022
34a3111
Maintain all original interfaces
cadnce Oct 13, 2022
a70c64b
Add deprecation warning to un-used parameters
cadnce Oct 13, 2022
12e22b7
Fix linting
cadnce Oct 13, 2022
d2c74e4
Bump gcs to 2.6.0
ddelange Dec 5, 2022
fc3475b
Fix linter
ddelange Dec 5, 2022
5bf7f45
Remove test for deprecated terminate method
ddelange Dec 5, 2022
9719063
Amend open docstring
ddelange Dec 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ def read(fname):


aws_deps = ['boto3']
gcs_deps = ['google-cloud-storage>=1.31.0']
gcs_deps = ['google-cloud-storage>=2.6.0']
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for future reference, this version bump relates to googleapis/python-storage#878 and the general maturing of the open interface in v2

azure_deps = ['azure-storage-blob', 'azure-common', 'azure-core']
http_deps = ['requests']

Expand Down
Loading