Add zstandard compression feature #801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpenkov
approved these changes
Feb 19, 2024
|
Whoops, looks like the linters failed. Can you please fix the error and push? |
|
Never mind, fixed it myself. Thanks for taking care of this! |
ddelange
added a commit
to ddelange/smart_open
that referenced
this pull request
Feb 21, 2024
…open into patch-2 * 'develop' of https://github.com/RaRe-Technologies/smart_open: Propagate __exit__ call to underlying filestream (piskvorky#786) Retry finalizing multipart s3 upload (piskvorky#785) Fix `KeyError: 'ContentRange'` when received full content from S3 (piskvorky#789) Add support for SSH connection via aliases from `~/.ssh/config` (piskvorky#790) Make calls to smart_open.open() for GCS 1000x faster by avoiding unnecessary GCS API call (piskvorky#788) Add zstandard compression feature (piskvorky#801) Support moto 4 & 5 (piskvorky#802) Secure the connection using SSL when connecting to the FTPS server (piskvorky#793) upgrade dev status classifier to stable (piskvorky#798) Fix formatting of python code (piskvorky#795)
|
Hi 👋 This PR only adds support for reading. @rlrs can you open another PR to fix writing? In [1]: from smart_open import open
In [2]: with open('~/Downloads/test.zst', 'w') as fp:
...: fp.write('abc')
...:
---------------------------------------------------------------------------
UnsupportedOperation Traceback (most recent call last)
Cell In[2], line 2
1 with open('~/Downloads/test.zst', 'w') as fp:
----> 2 fp.write('abc')
UnsupportedOperation: not writable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds zstandard compression support, as requested in #799.
I made it an optional feature, because it looks like every other feature that has dependencies is also an optional feature.
Obviously this means that the tests only work if the feature is installed.