Key pickling 2.0: reverse unused #31
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ard compatibility and keep the simple code
…n 1.x and 2.x + fixed tests
- spellfix compatibile => compatible - test_sqlite_migration.py was writing files to ./test/db, not ./tests/db. - use sys.version_info < (3, 0) rather than tracking _major_version. - Introduce 'unittest2' as development dependency, so that we can remove the TestCaseBackport class. - No longer necessary to use 'reraise', track inner or outer stack, as the next release of sqlitedict always pickles and there is no exception to handle - SqliteDict.__str__ depended on self.conn.filename always being set, but this is not necessarily True, esp. in test case teardown due to __del__. - add missing test coverage for throwing KeyError when any key (or value?!) cannot be unpickled.
|
@jquast I see the exception handling code has been removed in this PR. How vital was the code? Is it needed or not? I'd obviously prefer to have it removed, it obfuscates the code greatly. But I don't remember how critical it is, so I'm afraid to touch it. Can you comment? (I'm only talking about the inner/out stacks, not key encoding here) |
Closed
|
This PR looks abandoned, for this reason, I close it. |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on PR #30, retuning coverage to 100% and removing unused traceback handlers.