Fix for terminating tempfile error #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, thanks @adibo ! |
piskvorky
added a commit
that referenced
this pull request
Nov 27, 2015
Fix for terminating tempfile error
|
Cool, thanks! |
|
Hopefully this weekend... it's been on my TODO list for a while now. @tmylk can you tidy up PRs, changelog etc and release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Working with your excellent sqlitedict, regular debug exception occur upon terminating an index file being an instance of tempfile. I propose the following small fix to avoid any attempts to delete non-existing files.
I'd be grateful for a quick (minor) pip release.
Thanks for your great work!
Regards,
Adrian