Fix deadlock when connection fails #97
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wraps sqlite3.connect() in try/except and stores the exception to raise it in check_raise_error()
arnauorriols
force-pushed
the
fix-deadlock-when-connection-fails
branch
from
04ab11b to
2e5b23a
Compare
|
There seems to be a race-condition, still deadlocking sometimes. I'll check tomorrow. |
piskvorky
reviewed
Jun 21, 2019
| @@ -277,6 +287,6 @@ def test_tablenames(self): | |||
| self.assertEqual(SqliteDict.get_tablenames(fname), ['table1']) | |||
| with SqliteDict(fname,tablename='table2') as db2: | |||
| self.assertEqual(SqliteDict.get_tablenames(fname), ['table1','table2']) | |||
|
|
|||
There was a problem hiding this comment.
@mpenkov can we set up an automated git hook to check for these things?
Code with trailing whitespace should never have been merged.
| attempt_funcs = [attempt_write, | ||
| attempt_update, | ||
| attempt_funcs = [attempt_write, | ||
| attempt_update, |
There was a problem hiding this comment.
Hanging indent please (not vertical).
mpenkov
reviewed
Jan 30, 2021
| self.conn.execute(MAKE_TABLE) | ||
| self.conn.commit() | ||
| except sqlite3.OperationalError as e: | ||
| raise RuntimeError(str(e)) |
There was a problem hiding this comment.
Why is it better to raise RuntimeError than sqlite3.OperationalError here?
In my opinion, it's not a good idea because it hides useful information from the user.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wraps sqlite3.connect() in try/except
and stores the exception to raise it in check_raise_error()
Fixes #90