build: fix can't find rapidjson/prettywriter.h #1224
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If it needs to be added as a build dependency then you also need to add it to |
kiplingw
added
bug
fix in progress
dependencies
Tachi107
added a commit
that referenced
this pull request
Aug 3, 2024
Since a RapidJSON header is included in include/pistache/serializer/rapidjson.h, users using pistache must also add RapidJSON to their include path. Adding rapidjson_dep to the list of dependencies of pistache_dep makes rapidjson_dep a transitive (public) dependency, doing just that. Should fix the issue encountered by Duncan in <https://github.com/pistacheio/pistache/pull/1221/files#r1693921738>. Also closes #1224
|
now if I need pass tests, I should modify the workflows, and add before that expect your better reason. |
|
@Tachi107 Yeah, that's a better fix. |
dgreatwood
pushed a commit
to dgreatwood/pistachefork
that referenced
this pull request
Nov 1, 2024
Since a RapidJSON header is included in include/pistache/serializer/rapidjson.h, users using pistache must also add RapidJSON to their include path. Adding rapidjson_dep to the list of dependencies of pistache_dep makes rapidjson_dep a transitive (public) dependency, doing just that. Should fix the issue encountered by Duncan in <https://github.com/pistacheio/pistache/pull/1221/files#r1693921738>. Also closes pistacheio#1224
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1223
I found the
rapidjson_deponly used in example. And themesonseems to discard unused parameter information.So add
rapidjson_deptoexamples/meson.builddirectly maybe a better choice?