build: properly handle public dependencies #1232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since Pistache includes various headers from third party dependencies in its own public headers, it is necessary to mark the respective dependencies as public, so that consumers of the libpistache dependency will know that in addition to the include path of Pistache, they'll also have to look for OpenSSL headers, zlib headers, etc. Should fix an issue reported by Duncan via email.
|
I tried this out, seems to be working perfectly.
👍
…On Thu, Aug 22, 2024 at 8:06 AM Kip ***@***.***> wrote:
Merged #1232 <#1232> into
master.
—
Reply to this email directly, view it on GitHub
<#1232 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFMA25XOSUXA37UGJZLOFDZSX5A5AVCNFSM6AAAAABM5UX2VSVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJTHE3TQNZXGYZTCMA>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
--
NOTICE: This email and its attachments may contain privileged and
confidential information, only for the viewing and use of the intended
recipient. If you are not the intended recipient, you are hereby notified
that any disclosure, copying, distribution, acting upon, or use of the
information contained in this email and its attachments is strictly
prohibited and that this email and its attachments must be immediately
returned to the sender and deleted from your system. If you received this
email erroneously, please notify the sender immediately. Xage Security,
Inc. and its affiliates will never request personal information (e.g.,
passwords, Social Security numbers) via email. Report suspicious emails to
***@***.*** ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Pistache includes various headers from third party dependencies in its own public headers, it is necessary to mark the respective dependencies as public, so that consumers of the libpistache dependency will know that in addition to the include path of Pistache, they'll also have to look for OpenSSL headers, zlib headers, etc.
Should fix an issue reported by Duncan via email.