Fix: Enable use of subproject httplib in macOS despite nofallback #1270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On macOS, meson doesn't seem to find cpp-httplib even when cpp-httplib has been installed in the system (i.e. even when cpp-httplib has been installed with brew). This causes a particular issue with Pistache's brew formula, since brew's "std_meson_args", used by the formula, includes "--wrap-mode=nofallback", preventing meson from using our httplib subproject as a fallback (brew wants us to use brew to install each dependency, in preference to using a subproject). We workaround the issue in tests/meson.build by effectively doing the fallback to the cpp-httplib subproject without using meson dependency's "fallback:" option. bldscripts/nfbmesbuild.sh: Added convenience script to build with the "--wrap-mode=nofallback" option.
kiplingw
added
bug
portability
dependencies
kiplingw
approved these changes
Dec 13, 2024
dgreatwood
added a commit
to dgreatwood/pistachefork
that referenced
this pull request
Dec 22, 2024
As per PR pistacheio#1270, "Enable use of subproject httplib in macOS despite nofallback", the same workaround is now applied in Linux also, so Homebrew in Linux (aka Linuxbrew) can build Pistache.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On macOS, meson doesn't seem to find cpp-httplib even when cpp-httplib has been installed in the system (i.e. even when cpp-httplib has been installed with brew). This causes a particular issue with Pistache's brew formula, since brew's "std_meson_args", used by the formula, includes "--wrap-mode=nofallback", preventing meson from using our httplib subproject as a fallback (brew wants us to use brew to install each dependency, in preference to using a subproject). We workaround the issue in tests/meson.build by effectively doing the fallback to the cpp-httplib subproject without using meson dependency's "fallback:" option.
bldscripts/nfbmesbuild.sh: Added convenience script to build with the "--wrap-mode=nofallback" option.