C++23 aligned storage #1271
Merged
C++23 aligned storage #1271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since std::aligned_storage is deprecated in C++23, use `alignas` and an array of `std::bytes` as a replacement
sjoubert
force-pushed
the
cpp23_aligned_storage
branch
from
9a55a74 to
7b17e24
Compare
Ideally the construction should also use std::construct_at instead of a placement new but this would require C++20
sjoubert
force-pushed
the
cpp23_aligned_storage
branch
from
7b17e24 to
6065d6a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1271 +/- ##
==========================================
+ Coverage 75.72% 77.42% +1.70%
==========================================
Files 59 57 -2
Lines 9031 7669 -1362
==========================================
- Hits 6839 5938 -901
+ Misses 2192 1731 -461 ☔ View full report in Codecov by Sentry. |
|
kiplingw
approved these changes
Dec 13, 2024
|
Thanks @sjoubert. Looks fine to me. Thank you for those syntactical improvements. If there's no other feedback from my peers by the end of the weekend, remind me to merge if I forget. |
|
ping @kiplingw |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the usage of
std::aligned_storagethat is now deprecated in C++23 and replace it with an aligned array ofstd::bytethat is C++17 compliant.I've also replaced the manual destructor calls with
std::destroy_at(replacing placement new withstd::construct_atwould require C++20 so these are untouched). It is in a separate commit, I can just remove it or make a separate PR if you prefer.Side note: looking at various examples elsewhere I've seen a lot of usage of
std::launderthat seem missing here (mostly after eachreinterpret_cast). I have no idea how and why it is useful, but you might want to take a look at some point.