Migrate to MUI v5 #254
Merged
Migrate to MUI v5 #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [postcss](https://github.com/postcss/postcss) from 8.4.21 to 8.4.31. - [Release notes](https://github.com/postcss/postcss/releases) - [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md) - [Commits](postcss/postcss@8.4.21...8.4.31) --- updated-dependencies: - dependency-name: postcss dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [postcss](https://github.com/postcss/postcss) from 8.4.21 to 8.4.31. - [Release notes](https://github.com/postcss/postcss/releases) - [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md) - [Commits](postcss/postcss@8.4.21...8.4.31) --- updated-dependencies: - dependency-name: postcss dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [postcss](https://github.com/postcss/postcss) from 8.4.21 to 8.4.31. - [Release notes](https://github.com/postcss/postcss/releases) - [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md) - [Commits](postcss/postcss@8.4.21...8.4.31) --- updated-dependencies: - dependency-name: postcss dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
* Add web-ext and web-ext-types to dev dependencies * Add package.json script for load:msedge * Update README
|
Hi, Very nice job. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to build on this extension adding components from Material UI v5, but currently, it uses Material UI v4. Figured I'd separate the migration from any of my new additions and contribute back to the original repo :)
Even if you don't need any MUI v5 components, there are a number of reasons to migrate (https://mui.com/material-ui/migration/migration-v4/):
This also includes migration to the latest TypeScript version and migration from JSS to TSS, with better TypeScript support for styles.
I tested the changes manually with MS Edge on Google and Bing. There shouldn't be any visual or functional differences, before and after screenshots seemed identical:
One significant manual change was required in
content.tsxandResultsManagement.tsx-- the previous implementation was relying on the HTML structure of icon buttons which changed from material-ui v4 in mui v5:<button>contains<span>with<svg>icon inside<button>contains<svg>directlyInstead of attaching on click listeners, which pick the button from event target (button, svg, or path) based on their assumed HTML layout, I replaced it with passing a callback function through props. This also does away with needing to place
data-attributes on HTML elements.