Task 81 UI tests randomly fail #134
Conversation
Oxygen gives problem when running UI tests with Java 11: java.lang.NoClassDefFoundError: javax/annotation/PostConstruct Task-Url: http://github.com/pitest/pitclipse/issues/81
Otherwise we get another disturbing dialog for module-info.java when running with Java 11 Task-Url: http://github.com/pitest/pitclipse/issues/81
to include module arguments for Java 11 and for macOS UI tests Task-Url: http://github.com/pitest/pitclipse/issues/81
otherwise we cannot increase the timeout for building in the CI Task-Url: http://github.com/pitest/pitclipse/issues/81
I think it's crucial to understand what's going on during tests Task-Url: http://github.com/pitest/pitclipse/issues/81
|
@LorenzoBettini I just noticed that you're asking for a review, can I take a look at the code or are you still working on it? |
|
@echebbi i pushed a few more commits yesterday but this PR is ready for review |
| mutationIsSelected(mutation); | ||
| } | ||
|
|
||
| public void mutationIsSelected(PitMutation mutation) { |
There was a problem hiding this comment.
This method changes the current selection so wouldn't selectMutation or even selectMutationInMutationsViews be a better name?
There was a problem hiding this comment.
That's the same name as the one in the original Cucumber tests. But I agree: the name is misleading. Actually, it double clicks on the element on the view :)
What about doubleClickMutationInMutationsView?
There was a problem hiding this comment.
doubleClickMutationInMutationsView would be perfect
...g.pitest.pitclipse.ui.tests/src/org/pitest/pitclipse/ui/behaviours/steps/PitclipseSteps.java
Show resolved
Hide resolved
...g.pitest.pitclipse.ui.tests/src/org/pitest/pitclipse/ui/behaviours/steps/PitclipseSteps.java
Outdated
Show resolved
Hide resolved
tests/org.pitest.pitclipse.ui.tests/src/org/pitest/pitclipse/ui/swtbot/PitResultNotifier.java
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed! |
|
@echebbi do you think we can merge? |
|
@echebbi sorry to bother you again, but can I merge it? Because then I'll have additional PRs on top of the merge |
|
Hey @LorenzoBettini, I'm deeply sorry for the late answer. I'm very busy at work so if I don't review a PR in a few days please feel free to go on and assume I won't have the time to review it: I don't want to freeze the whole development. And yes, I think the branch can be merged! |
|
@echebbi OK, then I'll go on merging and I'll also create a few other PRs and if I don't hear from you I'll merge those ones as well. |
Closes #81
UI tests are written in SWTBot tests directly. Cucumber tests are disabled. Many existing testing codes are being used, but we can further refactor the project by keeping only what's required. So far so good :)
Tests are much less flaky (the SWTBot timeout had to be increased but at least everything seems to be much more synchronized and deterministic), see https://github.com/pitest/pitclipse/tree/task_81-UI_tests_randomly_fail
By the way, each single test method can be run in isolation :)