Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task 135 fix sonarqube issues #151

Merged
merged 62 commits into from
Jul 22, 2021
Merged

Task 135 fix sonarqube issues #151

merged 62 commits into from
Jul 22, 2021

Conversation

LorenzoBettini
Copy link
Collaborator

This is meant to

  • reduce several SonarQube issues
  • increase code coverage

Closes #135

@LorenzoBettini
81: Mutations.mutation private
58f0a85 
java:S1948

Fields in a "Serializable" class should either be transient or
serializable


Task-Url: http://github.com/pitest/pitclipse/issues/81
@LorenzoBettini
135: comment on empty method
230d23f 
java:S1186

Task-Url: http://github.com/pitest/pitclipse/issues/135
@LorenzoBettini
135: removed overridden methods taken from interface
262944f 
the interface already defines them as default empty methods

Task-Url: http://github.com/pitest/pitclipse/issues/135
@LorenzoBettini
135: removed duplicated code in content provider
7c0db1c 
Task-Url: http://github.com/pitest/pitclipse/issues/135
@LorenzoBettini
135: reduced cognitive complexity
6f4d631 
Task-Url: http://github.com/pitest/pitclipse/issues/135
@LorenzoBettini
135: removed useless boxing
e39b5ec 
Task-Url: http://github.com/pitest/pitclipse/issues/135
@LorenzoBettini
135: removed unused parameter 'mode'
da99bcf 
Task-Url: http://github.com/pitest/pitclipse/issues/135
@LorenzoBettini
135: ignore ignored exceptions in launch
0bb31bf 
Task-Url: http://github.com/pitest/pitclipse/issues/135
@LorenzoBettini
135: ignored returned null array
720e9fb 
since also Eclipse superclasses rely on that

Task-Url: http://github.com/pitest/pitclipse/issues/135
@LorenzoBettini
135: Abstract classes should not have public constructors
4b0d82e 
Task-Url: http://github.com/pitest/pitclipse/issues/135
@LorenzoBettini
135: renamed local var not to shadow field
3803d01 
Task-Url: http://github.com/pitest/pitclipse/issues/135
@LorenzoBettini
135: removed unused parameter
098be63 
Task-Url: http://github.com/pitest/pitclipse/issues/135
@LorenzoBettini
135: removed unused parameter
dc642e5 
Task-Url: http://github.com/pitest/pitclipse/issues/135
@LorenzoBettini
135: ignore constructor with lots of params used by builder
71e7d30 
Task-Url: http://github.com/pitest/pitclipse/issues/135
@LorenzoBettini
135: convert to lambdas and method references
0773894 
Task-Url: http://github.com/pitest/pitclipse/issues/135
@LorenzoBettini
135: converted to lambda
5c26d8a 
Task-Url: http://github.com/pitest/pitclipse/issues/135
@LorenzoBettini
135: converted to lambda
4900e35 
Task-Url: http://github.com/pitest/pitclipse/issues/135
@LorenzoBettini
135: renamed local var not to shadow field
da83e43 
Task-Url: http://github.com/pitest/pitclipse/issues/135
@LorenzoBettini
135: fixed use of Optional
cbb4b12 
Task-Url: http://github.com/pitest/pitclipse/issues/135
@LorenzoBettini
135: renamed field coverage -> percentage
79d475f 
Task-Url: http://github.com/pitest/pitclipse/issues/135
@LorenzoBettini
135: Guava Optional -> Java Optional
71bab79 
Task-Url: http://github.com/pitest/pitclipse/issues/135
@LorenzoBettini
135: removed launch of CoreException
9cce49c 
Task-Url: http://github.com/pitest/pitclipse/issues/135
@LorenzoBettini
135: removed publisher field
194f7a1 
only used as a local variable

Task-Url: http://github.com/pitest/pitclipse/issues/135
@LorenzoBettini
135: removed throws of PartInitException
b251116 
subclass of CoreException

Task-Url: http://github.com/pitest/pitclipse/issues/135
@LorenzoBettini
135: Use java.nio createTempDirectory
799f038 
instead of Guava Files.createTempDir

Task-Url: http://github.com/pitest/pitclipse/issues/135
@LorenzoBettini
135: Use java.nio createTempDirectory
69a0ab1 
Task-Url: http://github.com/pitest/pitclipse/issues/135
@LorenzoBettini
135: fixed createParentDirs
c899c3f 
Task-Url: http://github.com/pitest/pitclipse/issues/135
@LorenzoBettini
135: removed code blocks in switch
6ee636a 
Task-Url: http://github.com/pitest/pitclipse/issues/135
@LorenzoBettini
135: ignore security hotspot on temp file
d606778 
We use that only in tests anyway, from what I understand

Task-Url: http://github.com/pitest/pitclipse/issues/135
@LorenzoBettini
135: removed guava visible for testing annotations
c861d24 
Task-Url: http://github.com/pitest/pitclipse/issues/135
@LorenzoBettini
135: Private constructor in PitRunner
ca712a7 
Task-Url: http://github.com/pitest/pitclipse/issues/135
@LorenzoBettini
135: PitFileUtilsTest
4d1e450 
Task-Url: http://github.com/pitest/pitclipse/issues/135
@LorenzoBettini
135: find file in PitFileUtils
f281a16 
Task-Url: http://github.com/pitest/pitclipse/issues/135
@LorenzoBettini
135: Fix file utils test for Windows
c84e3ac 
Task-Url: http://github.com/pitest/pitclipse/issues/135
@LorenzoBettini
135: Also assert the console contents for multiple projects
cf18ac7 
Task-Url: http://github.com/pitest/pitclipse/issues/135
@LorenzoBettini
135: find file without Files.find
c10565d 
Task-Url: http://github.com/pitest/pitclipse/issues/135
@LorenzoBettini
Merge branch 'master' into task_135-Fix_SonarQube_issues
af41321
@LorenzoBettini
135: another test for PitOptions
c8451b0 
Task-Url: http://github.com/pitest/pitclipse/issues/135
@LorenzoBettini
135: removed rethrow
da4a9a1 
Task-Url: http://github.com/pitest/pitclipse/issues/135
@LorenzoBettini
135: don't use reflectionToString
1ab3e5e 
Task-Url: http://github.com/pitest/pitclipse/issues/135
@LorenzoBettini
135: excluded a few model classes from coverage
856d663 
Task-Url: http://github.com/pitest/pitclipse/issues/135
@LorenzoBettini
135: other tests for ObjectStreamSocket
3a7121b 
Task-Url: http://github.com/pitest/pitclipse/issues/135
@LorenzoBettini
135: SocketProvider returns if interrupted
1139413 
Task-Url: http://github.com/pitest/pitclipse/issues/135
@LorenzoBettini
135: corner case for PitClient.close
406ea6c 
Task-Url: http://github.com/pitest/pitclipse/issues/135
@LorenzoBettini
135: fixed doc
1c84c7c 
Task-Url: http://github.com/pitest/pitclipse/issues/135
@LorenzoBettini
135: removed TODO from PitCommunicator
98d7ddc 
Task-Url: http://github.com/pitest/pitclipse/issues/135
@LorenzoBettini
135: DetectionStatusConverter
2ee0657 
Task-Url: http://github.com/pitest/pitclipse/issues/135
@LorenzoBettini
135: printStackTrace in runPit
9cbd41e 
Task-Url: http://github.com/pitest/pitclipse/issues/135
@LorenzoBettini
135: test corner cases for PitOptions
8067450 
Task-Url: http://github.com/pitest/pitclipse/issues/135
@LorenzoBettini
Copy link
Collaborator Author

@echebbi I was wondering if you have some spare time to have a look at this. Mostly, these are cosmetic changes and additional testing scenarios

echebbi
echebbi approved these changes Jul 20, 2021
View reviewed changes
Copy link
Collaborator

@echebbi echebbi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments that are mostly related to naming. I don't see them as big issues so I'll approve the merge. Feel free to address my remarks if they seem relevant to you.

.../org.pitest.pitclipse.launch.ui/src/org/pitest/pitclipse/launch/ui/PitMigrationDelegate.java Outdated Show resolved Hide resolved
bundles/org.pitest.pitclipse.launch/src/org/pitest/pitclipse/launch/config/PackageFinder.java Show resolved Hide resolved
bundles/org.pitest.pitclipse.launch/src/org/pitest/pitclipse/launch/config/PackageFinder.java Show resolved Hide resolved
bundles/org.pitest.pitclipse.launch/src/org/pitest/pitclipse/launch/config/PackageFinder.java Show resolved Hide resolved
bundles/org.pitest.pitclipse.launch/src/org/pitest/pitclipse/launch/config/PackageFinder.java Show resolved Hide resolved
bundles/org.pitest.pitclipse.runner/src/org/pitest/pitclipse/runner/PitRunner.java Outdated Show resolved Hide resolved
@LorenzoBettini
Merge remote-tracking branch 'origin/HEAD' into
235e65d 
task_135-Fix_SonarQube_issues

Conflicts:
	releng/org.pitest.pitclipse.target/org.pitest.pitclipse.target.target
	tests/org.pitest.pitclipse.runner.tests/src/org/pitest/pitclipse/runner/io/ObjectStreamSocketTest.java
	tests/org.pitest.pitclipse.runner.tests/src/org/pitest/pitclipse/runner/io/SocketProviderIntegrationTest.java
	tests/org.pitest.pitclipse.runner.tests/src/org/pitest/pitclipse/runner/results/summary/Verification.java
@sonarcloud
Copy link

sonarcloud bot commented Jul 22, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

93.4% 93.4% Coverage
0.0% 0.0% Duplication

@LorenzoBettini LorenzoBettini merged commit fc8171f into master Jul 22, 2021
@LorenzoBettini LorenzoBettini deleted the task_135-Fix_SonarQube_issues branch July 22, 2021 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@echebbi echebbi echebbi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix a few SonarQube issues
2 participants
@LorenzoBettini @echebbi