-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Task 135 fix sonarqube issues #151
Conversation
java:S1948 Fields in a "Serializable" class should either be transient or serializable Task-Url: http://github.com/pitest/pitclipse/issues/81
the interface already defines them as default empty methods Task-Url: http://github.com/pitest/pitclipse/issues/135
since also Eclipse superclasses rely on that Task-Url: http://github.com/pitest/pitclipse/issues/135
only used as a local variable Task-Url: http://github.com/pitest/pitclipse/issues/135
subclass of CoreException Task-Url: http://github.com/pitest/pitclipse/issues/135
instead of Guava Files.createTempDir Task-Url: http://github.com/pitest/pitclipse/issues/135
We use that only in tests anyway, from what I understand Task-Url: http://github.com/pitest/pitclipse/issues/135
@echebbi I was wondering if you have some spare time to have a look at this. Mostly, these are cosmetic changes and additional testing scenarios |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few comments that are mostly related to naming. I don't see them as big issues so I'll approve the merge. Feel free to address my remarks if they seem relevant to you.
.../org.pitest.pitclipse.launch.ui/src/org/pitest/pitclipse/launch/ui/PitMigrationDelegate.java
Outdated
Show resolved
Hide resolved
bundles/org.pitest.pitclipse.launch/src/org/pitest/pitclipse/launch/config/PackageFinder.java
Show resolved
Hide resolved
bundles/org.pitest.pitclipse.launch/src/org/pitest/pitclipse/launch/config/PackageFinder.java
Show resolved
Hide resolved
bundles/org.pitest.pitclipse.launch/src/org/pitest/pitclipse/launch/config/PackageFinder.java
Show resolved
Hide resolved
bundles/org.pitest.pitclipse.launch/src/org/pitest/pitclipse/launch/config/PackageFinder.java
Show resolved
Hide resolved
bundles/org.pitest.pitclipse.runner/src/org/pitest/pitclipse/runner/PitRunner.java
Outdated
Show resolved
Hide resolved
task_135-Fix_SonarQube_issues Conflicts: releng/org.pitest.pitclipse.target/org.pitest.pitclipse.target.target tests/org.pitest.pitclipse.runner.tests/src/org/pitest/pitclipse/runner/io/ObjectStreamSocketTest.java tests/org.pitest.pitclipse.runner.tests/src/org/pitest/pitclipse/runner/io/SocketProviderIntegrationTest.java tests/org.pitest.pitclipse.runner.tests/src/org/pitest/pitclipse/runner/results/summary/Verification.java
Kudos, SonarCloud Quality Gate passed! |
This is meant to
Closes #135