Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task 154 build using the latest eclipse #156

Merged
merged 8 commits into from
Jul 26, 2021
Merged

Task 154 build using the latest eclipse #156

merged 8 commits into from
Jul 26, 2021

Conversation

LorenzoBettini
Copy link
Collaborator

Closes #154

@LorenzoBettini
Copy link
Collaborator Author

@echebbi as you can see, we also have a build that uses the old TP Photon, while the other builds all use the new TP.
Currently UI tests with Photon are still run (under Linux), if they start to fail we'll disable UI tests in the build that uses the old TP.

echebbi
echebbi reviewed Jul 24, 2021
View reviewed changes
.github/workflows/maven-old-tp.yml Outdated
Comment on lines 7 to 11
paths-ignore:
- 'README.md'
pull_request:
paths-ignore:
- 'README.md'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe ignore all markdowns (**.MD) to prevent builds when modifying the contribution guide and the changelog?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right! I'll do that!

@echebbi
Copy link
Collaborator

echebbi commented Jul 24, 2021

@echebbi as you can see, we also have a build that uses the old TP Photon, while the other builds all use the new TP.

@LorenzoBettini Perfect, thank you!

@sonarcloud
Copy link

sonarcloud bot commented Jul 26, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@LorenzoBettini LorenzoBettini merged commit bd00f0d into master Jul 26, 2021
@LorenzoBettini LorenzoBettini deleted the task_154-Build_using_the_latest_Eclipse branch July 26, 2021 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@echebbi echebbi echebbi left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build using the latest Eclipse platform
2 participants
@LorenzoBettini @echebbi