Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correcting the default init from preferences #181

Merged
merged 1 commit into from
Aug 25, 2021

Conversation

JKutscha
Copy link
Contributor

The current init of the preferences is broken and writes a wrong value in the mutators preference.

@LorenzoBettini
Copy link
Collaborator

That's something I had spotted in the past myself but never fixed that because I couldn't figure out how the bug actually revealed itself. How did you find the wrong behavior?

@JKutscha
Copy link
Contributor Author

I found this bug, after resetting my test workspace.

@LorenzoBettini
Copy link
Collaborator

I found this bug, after resetting my test workspace.

and what's the value it writes?

@JKutscha
Copy link
Contributor Author

and what's the value it writes?

I‘m not sure, if I understand. What value are you referring to?

@LorenzoBettini
Copy link
Collaborator

and what's the value it writes?

I‘m not sure, if I understand. What value are you referring to?

I mean, how have you detected that it was setting the wrong value?
When I opened my fresh workspace it was using the DEFAULT mutators (but I'm talking about the current released version, not the one under development), that's why when I spotted that strange setting I did not think about a bug since the behavior, in the end, was the expected one...

@JKutscha
Copy link
Contributor Author

I mean, how have you detected that it was setting the wrong value?
When I opened my fresh workspace it was using the DEFAULT mutators (but I'm talking about the current released version, not the one under development), that's why when I spotted that strange setting I did not think about a bug since the behavior, in the end, was the expected one...

The value was set to "defaultMutators" instead of the DEFAULTS.
I think this is the result of the rework I did on the preferences and the mutators itself.

@LorenzoBettini LorenzoBettini merged commit 31cbe1f into pitest:master Aug 25, 2021
@LorenzoBettini
Copy link
Collaborator

OK, merged! Thanks!

@JKutscha JKutscha deleted the Fix_preference_init branch August 25, 2021 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants