Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility ggplot2 3.6.0 #1

Merged
merged 1 commit into from
Feb 24, 2025

Conversation

teunbrand
Copy link
Contributor

Hi there,

Apologies for not posting an issue first.
The ggplot2 package is planning an update for around May 2025 and a reverse dependency test identified a problem with the agricolaeplotr package.
The details are explained in tidyverse/ggplot2#6290, but essentially ggplot2 doesn't populate the plot$labels field before plot building anymore, which violates some test assumptions in this package.

The tests that were checking for the length of the labels field were fragile (easy to break by even mild upstream changes), so this PR removes them.
You can test the changes yourself with the development version of ggplot2 (pak::pak("tidyverse/ggplot2"))

Best,
Teun

Copy link
Owner

@piusdahinden piusdahinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dear teunbrand,
Thank you for your contribution. I've checked the changes. It seems to work fine.
Kind regards,
Pius

@piusdahinden piusdahinden merged commit 0c156d2 into piusdahinden:master Feb 24, 2025
@teunbrand teunbrand deleted the ggplot2_360 branch February 24, 2025 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants