chore: drop dependency on github.com/pkg/errors #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This functionality is mostly available in the standard library (apart from stack traces), and it makes more sense to use the standard library equivalents rather to have a dependency.
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/187458076 The labels on this github issue will be updated when the story is started. |
zucchinidev
approved these changes
Apr 19, 2024
| @@ -23,7 +22,7 @@ func (sm ServiceMetadata) MarshalJSON() ([]byte, error) { | |||
|
|
|||
| b, err := json.Marshal(Alias(sm)) | |||
| if err != nil { | |||
| return []byte{}, errors.Wrap(err, "unmarshallable content in AdditionalMetadata") | |||
| return nil, fmt.Errorf("unmarshallable content in AdditionalMetadata: %w", err) | |||
| } | |||
|
|
|||
| var m map[string]interface{} | |||
There was a problem hiding this comment.
The error returned by json.Unmarshal operation in line 29 is not being checked. It's a good practice in Go to always check for errors. I know it is out of the scope of the PR, but you may want to add the logic
There was a problem hiding this comment.
Thanks @zucchinidev. I'll handle this in #303
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This functionality is mostly available in the standard library (apart from stack traces), and it makes more sense to use the standard library equivalents rather to have a dependency.