Gradle migration #144
Merged
Gradle migration #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spikymonkey
force-pushed
the
gareth/gradle
branch
3 times, most recently
from
b2ac64f to
408efc2
Compare
spikymonkey
commented
Jun 30, 2021
| @@ -78,7 +77,7 @@ public void postProcessEnvironment(ConfigurableEnvironment environment, | |||
|
|
|||
| increaseInvocationCount(); | |||
| if (CloudPlatform.CLOUD_FOUNDRY.isActive(environment)) { | |||
| CfEnv cfEnv = CfEnvSingleton.getCfEnvInstance(); | |||
| CfEnv cfEnv = new CfEnv(); | |||
There was a problem hiding this comment.
Required to get CfEnv to reparse the environment. Otherwise it's cached in the singleton, which then causes failures in tests which expect CfEnv to be looking at an updated (mocked) env.
spikymonkey
commented
Jun 30, 2021
| include "java-cfenv-boot" | ||
| include "java-cfenv-boot-pivotal-scs" | ||
| include "java-cfenv-boot-pivotal-sso" | ||
| //include "java-cfenv-docs" |
There was a problem hiding this comment.
Parity with the Maven setup - we haven't written any docs yet.
* Consistency with other Spring projects * Simplifies upcoming publication pipeline work * Faster build
spikymonkey
force-pushed
the
gareth/gradle
branch
from
408efc2 to
072dc5b
Compare
spikymonkey
force-pushed
the
gareth/gradle
branch
from
89e1b43 to
061ebb9
Compare
spikymonkey
force-pushed
the
gareth/gradle
branch
from
061ebb9 to
24f4688
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.