fix(sortable-table): refactor sortable-table to rerender with data change #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctaymor
force-pushed
the
redesign-sortable-table-97658788
branch
3 times, most recently
from
43a1b04
to
eb12de6
Compare
|
@gpleiss - I'd like for both of use to code review this one, do you mind? |
| @@ -120,5 +118,4 @@ module.exports = { | |||
| BackToTop: require('pui-react-back-to-top').BackToTop, | |||
|
|
|||
| PortalSource: require('pui-react-portals').PortalSource, | |||
| PortalDestination: require('pui-react-portals').PortalDestination | |||
| }; | |||
| PortalDestination: require('pui-react-portals').PortalDestination, ...sortableTable}; | |||
There was a problem hiding this comment.
eww... why is this all on one line? :)
gpleiss
force-pushed
the
redesign-sortable-table-97658788
branch
from
eb12de6
to
c97dc35
Compare
|
So before this PR can be merged we need to address the non-sortable first column bug. Then this should be ready for merge IMO. |
…ange New interface for sortable-table, which also fixes the bug where the table didn't rerender when the data changed. [Finishes #97658788] BREAKING CHANGE: (javascript) React component has new wrapping components for the header and rows.
instead of on the first column regardless of whether it was sortable. Also refactors to use mergeprops. [Finishes #97658788]
kennyw12
force-pushed
the
redesign-sortable-table-97658788
branch
from
c97dc35
to
c3b2fa0
Compare
stubbornella
added a commit
that referenced
this pull request
Jul 18, 2015
fix(sortable-table): refactor sortable-table to rerender with data change
aks-
pushed a commit
to aks-/pivotal-ui
that referenced
this pull request
Oct 25, 2016
fix(buttons): Update button version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New interface for sortable-table, which also fixes the bug where the
table didn't rerender when the data changed.
[Finishes #97658788]
BREAKING CHANGE: (javascript) React component has new wrapping components for
the header and rows.