Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default value to Change.diffSide in CodeTF #240

Merged
merged 1 commit into from
Feb 6, 2024
Merged

Add default value to Change.diffSide in CodeTF #240

merged 1 commit into from
Feb 6, 2024

Conversation

drdavella
Copy link
Member

Overview

Add diffSide to Change entry in CodeTF

Description

  • The CodeTF spec now requires this field: Update spec to require diffSide for changes codemodder-specs#15
  • Since all of our descriptions and line numbers are currently phrased in terms of additive changes/modifications, we default to the RIGHT side of diffs
  • Eventually it may be useful to use LEFT for certain kinds of changes as well

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 6, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

4.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@drdavella drdavella added this pull request to the merge queue Feb 6, 2024
Merged via the queue into main with commit cccc8a7 Feb 6, 2024
12 of 13 checks passed
@drdavella drdavella deleted the update-codetfchange-diffside branch February 6, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrecsilva andrecsilva andrecsilva approved these changes

@clavedeluna clavedeluna Awaiting requested review from clavedeluna clavedeluna is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drdavella @andrecsilva