Skip to content

Commit

Permalink
Revamp the test_subscription.cpp tests. (ros2#2227)
Browse files Browse the repository at this point in the history
The original motiviation to do this was a crash during
teardown when using a newer version of gtest.  But while
I was in here, I did a small overall cleanup, including:

1.  Moving code closer to where it is actually used.
2.  Getting rid of unused 'using' statements.
3.  Adding in missing includes.
4.  Properly tearing down and recreating the rclcpp
    context during test teardown (this fixed the actual
    bug).
5.  Making class members private where possible.
6.  Renaming class methods to our usual conventions.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
(cherry picked from commit 2e355e4)
  • Loading branch information
clalancette authored and jplapp committed May 17, 2024
1 parent 75e1be9 commit df1bd84
Showing 1 changed file with 213 additions and 221 deletions.
Loading

0 comments on commit df1bd84

Please sign in to comment.