Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ FIX ] enable controller in SLOT env #34

Merged
merged 2 commits into from
Sep 21, 2024
Merged

[ FIX ] enable controller in SLOT env #34

merged 2 commits into from
Sep 21, 2024

Conversation

posaune0423
Copy link
Contributor

@posaune0423 posaune0423 commented Sep 21, 2024 •
edited
Loading

Changes

  • set rpc propery to work controller in slot as well
  • fix interaction problem

@posaune0423 posaune0423 added the enhancement New feature or request label Sep 21, 2024
@posaune0423 posaune0423 self-assigned this Sep 21, 2024
@posaune0423
Copy link
Contributor Author

@0xshora
NOTE:
Somehow provider.excute() function is so snsitive about the params order we passes, and when I pass the defaultParams incorrect order, it parse the color to 0, and inside contract, fade() called instead of pu_color(), that's why we cannot paint any pixels by newer systems calls but now fixed. and please be carefull about params order

@0xshora 0xshora merged commit d6a3324 into master Sep 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xshora 0xshora 0xshora approved these changes

Assignees

@posaune0423 posaune0423

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@posaune0423 @0xshora