fix: remove redundant option

pixelfusion · Jul 18, 2023 · c3eed46 · c3eed46
1 parent aaa39ac
commit c3eed46
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 7 deletions.
diff --git a/gatsby-plugin-s3/src/bin.ts b/gatsby-plugin-s3/src/bin.ts
@@ -158,7 +158,7 @@ export const deploy = async ({ yes, bucket, userAgent }: DeployArguments = {}) =
         }
 
         const agent = makeAgent()
-        const maxRetryAttempts = config.maxRetryAttempts || DEFAULT_OPTIONS.maxRetries as number
+        const maxRetries = config.maxRetries || DEFAULT_OPTIONS.maxRetries as number
         const s3 = new S3({
             region: config.region,
             endpoint: config.customAwsEndpointHostname,
@@ -171,8 +171,8 @@ export const deploy = async ({ yes, bucket, userAgent }: DeployArguments = {}) =
             }),
             logger: config.verbose ? console : undefined,
             retryStrategy: config.fixedRetryDelay
-                ? new ConfiguredRetryStrategy(maxRetryAttempts, config.fixedRetryDelay)
-                : new StandardRetryStrategy(maxRetryAttempts),
+                ? new ConfiguredRetryStrategy(maxRetries, config.fixedRetryDelay)
+                : new StandardRetryStrategy(maxRetries),
         });
 
         const { exists, region } = await getBucketInfo(config, s3);

diff --git a/gatsby-plugin-s3/src/constants.ts b/gatsby-plugin-s3/src/constants.ts
@@ -110,9 +110,6 @@ export interface S3PluginOptions extends PluginOptions {
     // Use this option to use a fixed retry delay instead of exponential for particularly flaky connections
     fixedRetryDelay?: number;
 
-    // Max number of retry attempts.
-    maxRetryAttempts?: number;
-
     // Whether or not the plugin should output verbose logs from S3 uploads
     verbose?: boolean;
 }
@@ -131,7 +128,7 @@ export const DEFAULT_OPTIONS: S3PluginOptions = {
     retainObjectsPatterns: [],
     enableS3StaticWebsiteHosting: true,
     parallelLimit: 20,
-    maxRetryAttempts: 3,
+    maxRetries: 3,
 
     // the typing requires this for some reason...
     plugins: [],