Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

folder name fix #49

Merged
merged 4 commits into from
Aug 14, 2017
Merged

folder name fix #49

merged 4 commits into from
Aug 14, 2017

Conversation

bencmbrook
Copy link
Contributor

This updates folder names to be consistent with their file paths. It only changes the letter casing (which causes the file lookup to fail for some webservers).

closes #48

@bencmbrook
Copy link
Contributor Author

bencmbrook commented Aug 13, 2017

And one thing to note-- the imac and iMac folders were combined in this PR, which moves the .PSD into the folder. I figured this combination was okay, since this is consistent with other devices' folders. The same goes for the .PSDs in surface and ipad.

In total, this PR changes

  • rename macbook to Macbook
  • rename iphone5 to iPhone5
  • merge imac into iMac
  • merge surface into Surface
  • merge ipad into iPad

@ben182
Copy link
Collaborator

ben182 commented Aug 13, 2017

Hi @bencmbrook,

will this affect the css image paths? Have you tested this?

@bencmbrook
Copy link
Contributor Author

Hey @ben182, the CSS image paths remain as they were. The data-device attributes always used proper capitalization, so the paths always resolved to the correct capitalized case. In other words, there are no API changes and it should not break any existing projects.

I've tested this, and it's running properly now on my production server (which was failing before due to the mismatched letter casing).

And thanks for this awesome repo!

@ben182 ben182 merged commit db83094 into pixelsign:master Aug 14, 2017
@ben182
Copy link
Collaborator

ben182 commented Aug 14, 2017

Okay thanks for the help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Macbook" filepath mismatch of letter cases
2 participants