-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vaft userscript on firefox testing #222
Comments
This is due to #220 and should be fixed in 9bd481a I'm not sure if the freezing issues are also related or not. There have been other freezing related issues for a while though so I'm going to close this in favor of the already open issues #119 / #164 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I am using violetmonkey addon and get varied results with the vaft userscript
Here are some tests I have done changing violetmonkey injection modes, what I hope is useful information:
Synchronous page mode:
This setting works the best when a midroll ad starts but desync will occur after midroll ads. instant injection is to soon function findReactNode() and fails to find the videoPlayer, so it does not pause then play after ads what causes sync issues
Alternate page mode for firefox (default for violentmonkey):
Video always freezes during ads. The video resolution of the player changes a few times causing it to freeze. Resumes fine after ad is finished
Alt mode and Synchronous mode both off:
Infinite Buffer when a midroll ad starts. Manual pause then play fixes it. Resumes fine after ad is finished
solution?:
I think if the script uses Synchronous page mode then pause then play after "blocking ads" overlay is removed from the video player this script will run flawless because I saw 2-3 midrolls over a few hours and I manually paused then played after each ad to fix the desync and it worked without issues
ty
The text was updated successfully, but these errors were encountered: