Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no blocking anymore #220

Closed
stefabaldi opened this issue Feb 18, 2024 · 12 comments
Closed

no blocking anymore #220

stefabaldi opened this issue Feb 18, 2024 · 12 comments

Comments

@stefabaldi
Copy link

when the ads come up the stream start loading and when i try to refresh the page the ad isn't blocked. Other times i see the "blocking mid-roll ads" but the ads aren't blocked at all.

@revunix
Copy link

revunix commented Feb 18, 2024

Use TTV LOL PRO

@phireblast
Copy link

Use TTV LOL PRO

this still happens with TTV LOL PRO

@revunix
Copy link

revunix commented Feb 20, 2024

Use TTV LOL PRO

this still happens with TTV LOL PRO

No, it isn't. I'm using it with a own proxy from https://proxy6.net (china proxy) and it works perfectly since months!

@pixeltris
Copy link
Owner

I can reproduce this. Under video-swap-new I've observed a few different things:

  • Ads being displayed
  • Player load errors
  • Stream resolution getting stuck at 240p

I think it's mostly midroll issues but may also impact prerolls. I'll look at possible solutions.

@Fe-n
Copy link

Fe-n commented Feb 22, 2024

I can reproduce this. Under video-swap-new I've observed a few different things:

* Ads being displayed

* Player load errors

* Stream resolution getting stuck at 240p

I think it's mostly midroll issues but may also impact prerolls. I'll look at possible solutions.

Thank you. I've also noticed issues with video-swap-new the last few days, but I wasn't sure if it was a transient issue or possibly caused by my sort-of out-of-date BTTV (the Firefox release lags behind the other releases) and hadn't looked into it more yet.

My experience has been:

  • No pre-roll ads observed when first loading a stream. The low-res embed player seems to be correctly used when they would otherwise play. However, the higher resolution is not swapped to, and unlike at some points in the past, pausing and then unpausing the player does not force a switch. Refreshing the page will either result in ads playing (I think this happened once?) or the stream playing normally at selected resolution.
  • When mid-roll ads are meant to be played, the stream simply stops playback. Pausing and then un-pausing the player will result in the ads playing.

@JTJutajoh
Copy link

In the meantime, I've found that I can fix the "stuck at 240p" part by waiting a few minutes for ads to finish, then using the FFZ "Reset Player" button.

@sangohan
Copy link

@Fe-n

However, the higher resolution is not swapped to, and unlike at some points in the past

i had the same issue, but the temporary fix is to click onto another channel, and click back to the original channel. Twitch seems to prevent ads from playing constantly, so there's a timeout/grace period. This means you get back to the high res video (no swaps happening in this circumstance).

I suspect it's just the player on twitch changing and the code not keeping up,

pixeltris added a commit that referenced this issue Feb 23, 2024
@pixeltris
Copy link
Owner

Should be fixed by 9bd481a

@stefabaldi
Copy link
Author

updated today the new version, now the loading neither starts, ads start normally

@Matthewkyos
Copy link

even with this patch its still broken
image
image

@pixeltris
Copy link
Owner

Use the userscript version. I updated the readme recently with an additional note about the uBlock Origin script issues:

The scripts may randomly stop being applied by uBlock Origin for unknown reasons (#200). It's recommended to use the userscript versions instead.

Closing this as I imagine most people who use the scripts are up to date.

@pseeghosts
Copy link

tried all the url options and none of them held the ads :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants