Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vaft and video-swap-new script need daily purge & update in ublock to work ? Getting ads everyday in Twitch. #200

Closed
Elaws opened this issue Nov 6, 2023 · 15 comments

Comments

@Elaws
Copy link

Elaws commented Nov 6, 2023

I tested vaft and video-swap-new scripts and unfortunately I get ads every day in Twitch. Sometimes, after purging and updating the filters in ublock, the ads disappear. But for a week I've had to do this everyday : is this the expected behavior ?

Thank you.

Context :

  • Firefox v. 119.0

  • Ublock origin v. 1.53.0

  • Windows 11 build 22621

  • My filters :

twitch.tv##+js(twitch-videoad)
  • Ublock advanced settings :
userResourcesLocation https://github.com/pixeltris/TwitchAdSolutions/raw/master/video-swap-new/video-swap-new-ublock-origin.js
@Elaws Elaws changed the title Vaft and video-swap-new script need daily purge & update ublock to work ? Vaft and video-swap-new script need daily purge & update in ublock to work ? Getting ads everyday in Twitch. Nov 6, 2023
@RedSnt
Copy link

RedSnt commented Nov 6, 2023

µBlock has been aggressively been updating Youtube adblock lately, might be related to that requiring daily updating somehow?

@gwarser
Copy link

gwarser commented Nov 6, 2023

Try using permalink.

You should add the filter and resource link, and it should just work. Without a need for purge-update, because there are no updates for Twitch filters.

@Elaws
Copy link
Author

Elaws commented Nov 6, 2023

Try using permalink.

You should add the filter and resource link, and it should just work. Without a need for purge-update, because there are no updates for Twitch filters.

Thanks : isn't it what I already did ? I followed procedure described here : https://github.com/pixeltris/TwitchAdSolutions#applying-a-script-ublock-origin.

@gwarser
Copy link

gwarser commented Nov 6, 2023

Try using the link marked "ublock (permalink)". The auto-updated one have redirection, maybe this causes issues.

@pixeltris
Copy link
Owner

Yea that seems to happen semi often. It could indeed be that redirect. I'll update them at some point to avoid the redirect.

@MonfGeiger
Copy link

weird, i use the userscript version in tampermonkey along with the refresh on advert twitch userscript, and combined with my ublock origin, while i get the "Blocking midroll ads" warning on the top left of the stream window along with the resolution going to 144p/toaster mode, i don't get very little, if ANY ads anymore. the permalink ublock versions ceased working out for me, and these two scripts so far along with ublock have worked out pretty damn good so far (for me at least) :/

@spencerharmon
Copy link

Using the ublock url (not permalink) I also got an ad today for the first time in a while. If it happens again, I'll change to permalink and update here.

@Teapsalm
Copy link

I've tried literally all of the "solutions" and none of them have worked for some time. Twitch won.

@Suprcheese
Copy link

I've tried literally all of the "solutions" and none of them have worked for some time. Twitch won.

Vaft still works for me.

@cheatreal321
Copy link

Same issue here, been getting ads again for the last few weeks and I've tried disabling and re-enabling uBlock, cache purges and refreshes, countless browser restarts, different links under userResourcesLocation, but everytime I try to window.reloadTwitchPlayer it prints undefined

@Matthewkyos
Copy link

@pixeltris whats the right way to set these because im still getting ads?
image
image

@Matthewkyos
Copy link

image

@pixeltris
Copy link
Owner

That should work. You probably don't want to put the url in the filter list itself but it probably shouldn't have any impact. As mentioned in this issue uBlock Origin stops applying the script after some time. This persists perpetually once it happens. You used to be able to purge to fix it but I'm not sure how you'd fix it since they removed that functionality. I can't really help beyond this info unfortunately.

@Matthewkyos
Copy link

That should work. You probably don't want to put the url in the filter list itself but it probably shouldn't have any impact. As mentioned in this issue uBlock Origin stops applying the script after some time. This persists perpetually once it happens. You used to be able to purge to fix it but I'm not sure how you'd fix it since they removed that functionality. I can't really help beyond this info unfortunately.
I assume this is the correct way to set up the userscripts?
image

@pixeltris
Copy link
Owner

Closing as I don't have any plans to look into this.

As far as I know something causes uBlock Origin to stop injecting the script after some time. Refresh / new tabs don't help. When the purge button existed that would fix it but I assume now the only way to fix it is to disable / enable the extension (not 100% sure). To fix this issue you would need to do some debugging somewhere in uBlock Origin and create a PR over there.

Its been a while since I properly tested the scripts so if this is already fixed or if it gets fixed in the future feel free to leave a comment below and I'll remove the note in the README:

The scripts may randomly stop being applied by uBlock Origin for unknown reasons (#200). It's recommended to use the userscript versions instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants