-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make it rails 3.2.11 compatible. #4
base: master
Are you sure you want to change the base?
Conversation
Hmm, I don't think we should set both - we should try to do some feature detection. I think Rails 4 had a backwards compatible mode for secret_token - maybe you can look at that as a starting point? |
Ok, I'll give it another shot. |
@raskhadafi yes, please do update the tests - if you want to you could adapt them to use the appraisal gem to make sure it works across both 3.2 and 4.0. |
… or secret_token is properly set.
I did a little research and in the rails guides under the point 4.7 Action Pack they recommend to set both.
So my solution should work. What do you think @pixeltrix ? |
An alternate solution would be to change the railtie to use before_initialize, then we could modify our 3.2 secret_token.rb to RailsFrontend::Application.config.secret_token = RailsFrontend::Application.config.secret_key_base @pixeltrix I could do a pull request for the change if your interested. |
Rails 3.2 uses to store the secret_key the config secret_token.
So I extended the initializer. Can you merge it?
Thanks in advance.