Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support rails 3 secret_token #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nijikon
Copy link

@nijikon nijikon commented Aug 10, 2015

No description provided.

@nijikon
Copy link
Author

nijikon commented Aug 10, 2015

/cc @pixeltrix

@pixeltrix
Copy link
Owner

@nijikon I think there's actually two scenarios we need to address

  1. Rails 3.2.x
    Copy across app.secrets.secret_token
  2. Rails 4.0.x
    Copy across app.secrets.secret_key_base and app.secrets.secret_token but only if they are set

This is to cover the various possible settings when upgrading from Rails 3.2.x to Rails 4.0.x. Additionally, I think we need to add a integration test that sets a value in a session and then goes to another page and asserts the value from the session.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants