-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dashboard variables #44
Conversation
Is there a reason we use a different syntax here ($ vs __ prefix) than the time/interval special variables? I would recommend using the same approach for both |
Also, looks like the commit history might be including some other stuff |
This is actually replacing the variables directly in Grafana UI. Previously we handled the The Grafana UI actually just replaces the
I will rebase on main in a moment. |
So you're saying that the $ replacement is done by Grafana, not manual logic on our side. In that case, we might want to support We can therefore update our Grafana plugin to support both and update our example scripts to use $ |
Signed-off-by: Taras Priadka <tpriadka@pixielabs.ai>
06d4e1c
to
cea6c44
Compare
The equivalent with Grafana global variables are |
Signed-off-by: Taras Priadka <tpriadka@pixielabs.ai>
Add support for dashboard variables. Depends on #42
For example here,
The
$clusters
will get replaced with the dashboard variable value.