Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] UI crashed in self hosted pixie cloud #348

Closed
domechn opened this issue Nov 5, 2021 · 1 comment
Closed

[BUG] UI crashed in self hosted pixie cloud #348

domechn opened this issue Nov 5, 2021 · 1 comment
Assignees

Comments

@domechn
Copy link
Contributor

domechn commented Nov 5, 2021

Describe the bug

ui creashed when clicking the "Admin" Button (self hosted plc)

image

Screenshots

image

Logs

Cannot destructure property 'embedState' of 'i.useContext(...)' as it is null.
    in Unknown
    in Jn
    in div
    in eo
    in to
    in t
    in t
    in ro
    in t
    in t
    in Zu
    in t
    in t
    in div
    in t
    in C
    in Ed
    in Unknown
    in ForwardRef
    in l
    in Ei
    in d
    in l
    in f
    in wd
    in ie
    in _r
    in s
    in Ed

Raw error:
  at TypeError: Cannot destructure property 'embedState' of 'i.useContext(...)' as it is null.
  at     at https://pixie.local.dev/static/main.3a4576a542a367220952.js:213:17597
  at     at Xo (https://pixie.local.dev/static/vendor.009f72be365e30d37d87.js:101:432776)
  at     at La (https://pixie.local.dev/static/vendor.009f72be365e30d37d87.js:101:441625)
  at     at ja (https://pixie.local.dev/static/vendor.009f72be365e30d37d87.js:101:441444)
  at     at Ma (https://pixie.local.dev/static/vendor.009f72be365e30d37d87.js:101:441127)
  at     at vs (https://pixie.local.dev/static/vendor.009f72be365e30d37d87.js:101:482209)
  at     at fu (https://pixie.local.dev/static/vendor.009f72be365e30d37d87.js:101:471457)
  at     at gu (https://pixie.local.dev/static/vendor.009f72be365e30d37d87.js:101:471382)
  at     at ru (https://pixie.local.dev/static/vendor.009f72be365e30d37d87.js:101:468412)
  at     at https://pixie.local.dev/static/vendor.009f72be365e30d37d87.js:101:420191

App information (please complete the following information):

  • Pixie Cloud version: 1636161793 (image tag), pulled at 2021-11-05
  • K8s cluster version: 1.18.20-eks

Additional context
Add any other context about the problem here.

@domechn domechn changed the title UI crashed in self hosted pixie cloud [BUG] UI crashed in self hosted pixie cloud Nov 5, 2021
copybaranaut pushed a commit that referenced this issue Nov 9, 2021
Summary: LiveRouteContext isn't available outside the live views, and the sidebar was ignoring that. Not sure how we didn't trigger this before now.

Test Plan: Visit the admin pages. On main, that crashes the UI. With this, it doesn't.

Reviewers: michelle, vihang

Reviewed By: vihang

Subscribers: nserrino

Signed-off-by: Nick Lanam <nlanam@pixielabs.ai>

Differential Revision: https://phab.corp.pixielabs.ai/D10134

GitOrigin-RevId: b895683
@NickLanam
Copy link
Member

Fixed in 6f0c8d0. It originally broke in 77a3e3c due to an oversight on my part when reviewing. Sorry about that!

@vihangm vihangm closed this as completed Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants